diff options
| author |   Eddie James <eajames@linux.ibm.com> | 2019-06-26 13:56:55 -0500 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-07-03 21:17:11 +0200 |
| commit | 7ce98fb6c53d2311b3e9faae90b1a9c1a96534db (patch) | |
| tree | d23ef32a1067922e6009327499833843d4be2964 /drivers/fsi/fsi-sbefifo.c | |
| parent | coresight: tmc: Smatch: Fix potential NULL pointer dereference (diff) | |
| download | linux-dev-7ce98fb6c53d2311b3e9faae90b1a9c1a96534db.tar.xz linux-dev-7ce98fb6c53d2311b3e9faae90b1a9c1a96534db.zip | |
fsi: sbefifo: Don't fail operations when in SBE IPL state
SBE fifo operations should be allowed while the SBE is in any of the
"IPL" states. Operations should succeed in this state.
Fixes: 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO
Reviewed-by: Joel Stanley <joel@jms.id.au>
Tested-by: Alistair Popple <alistair@popple.id.au>
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/1561575415-3282-1-git-send-email-eajames@linux.ibm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/fsi/fsi-sbefifo.c')
| -rw-r--r-- | drivers/fsi/fsi-sbefifo.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index d92f5b87c251..f54df9ebc8b3 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -289,11 +289,11 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >> CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN: return -ESHUTDOWN; + case SBE_STATE_DMT: + return -EBUSY; case SBE_STATE_IPLING: case SBE_STATE_ISTEP: case SBE_STATE_MPIPL: - case SBE_STATE_DMT: - return -EBUSY; case SBE_STATE_RUNTIME: case SBE_STATE_DUMP: /* Not sure about that one */ break; |