diff options
| author |   Rashmica Gupta <rashmica.g@gmail.com> | 2019-09-06 16:26:22 +1000 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2019-09-11 11:04:55 +0100 |
| commit | 3c4710ae6f883f9c6e3df5e27e274702a1221c57 (patch) | |
| tree | fce94c43e42f2e93715fabb2d3c16cbb031f96d8 /drivers/gpio/gpio-aspeed.c | |
| parent | gpio: aspeed: Update documentation with ast2600 controllers (diff) | |
| download | linux-dev-3c4710ae6f883f9c6e3df5e27e274702a1221c57.tar.xz linux-dev-3c4710ae6f883f9c6e3df5e27e274702a1221c57.zip | |
gpio/aspeed: Fix incorrect number of banks
The current calculation for the number of GPIO banks is only correct if
the number of GPIOs is a multiple of 32 (if there were 31 GPIOs we would
currently say there are 0 banks, which is incorrect).
Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver')
Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Link: https://lore.kernel.org/r/20190906062623.13354-1-rashmica.g@gmail.com
Reviewed-by: Joel Stanley <joel@jms.d.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-aspeed.c')
| -rw-r--r-- | drivers/gpio/gpio-aspeed.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 7bcd83dbc3e3..854ed3bc66a7 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -1168,7 +1168,7 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev) gpio->chip.base = -1; /* Allocate a cache of the output registers */ - banks = gpio->config->nr_gpios >> 5; + banks = DIV_ROUND_UP(gpio->config->nr_gpios, 32); gpio->dcache = devm_kcalloc(&pdev->dev, banks, sizeof(u32), GFP_KERNEL); if (!gpio->dcache) |