diff options
| author |   Zhouyang Jia <jiazhouyang09@gmail.com> | 2018-06-12 11:28:52 +0800 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2018-06-18 07:55:30 +0200 |
| commit | f3a049e784b337e9fa08f2f9046c955cc80af535 (patch) | |
| tree | 40af082f433818e4666e2c0d2e9ae405a109a35b /drivers/gpio/gpio-max732x.c | |
| parent | gpio: davinci: Do not assume continuous IRQ numbering (diff) | |
| download | linux-dev-f3a049e784b337e9fa08f2f9046c955cc80af535.tar.xz linux-dev-f3a049e784b337e9fa08f2f9046c955cc80af535.zip | |
gpio: max732x: add error handling for i2c_new_dummy
When i2c_new_dummy fails, the lack of error-handling code may
cause unexpected results.
This patch adds error-handling code after calling i2c_new_dummy.
Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-max732x.c')
| -rw-r--r-- | drivers/gpio/gpio-max732x.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c index 9d8bcc69f245..f03cb0ba7726 100644 --- a/drivers/gpio/gpio-max732x.c +++ b/drivers/gpio/gpio-max732x.c @@ -653,6 +653,12 @@ static int max732x_probe(struct i2c_client *client, chip->client_group_a = client; if (nr_port > 8) { c = i2c_new_dummy(client->adapter, addr_b); + if (!c) { + dev_err(&client->dev, + "Failed to allocate I2C device\n"); + ret = -ENODEV; + goto out_failed; + } chip->client_group_b = chip->client_dummy = c; } break; @@ -660,6 +666,12 @@ static int max732x_probe(struct i2c_client *client, chip->client_group_b = client; if (nr_port > 8) { c = i2c_new_dummy(client->adapter, addr_a); + if (!c) { + dev_err(&client->dev, + "Failed to allocate I2C device\n"); + ret = -ENODEV; + goto out_failed; + } chip->client_group_a = chip->client_dummy = c; } break; |