aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-pca953x.c
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2016-09-09 09:31:54 +0100
committerLinus Walleij <linus.walleij@linaro.org>2016-09-12 15:39:39 +0200
commit313b9a9938bf4076425741121d5d766826793e5d (patch)
tree4ba834a36ad066205049ef5c21ee016466af2f29 /drivers/gpio/gpio-pca953x.c
parentgpio: iop: Use generic GPIO MMIO functions for driver (diff)
downloadlinux-dev-313b9a9938bf4076425741121d5d766826793e5d.tar.xz
linux-dev-313b9a9938bf4076425741121d5d766826793e5d.zip
gpio: pca953x: initialize ret to zero to avoid returning garbage
ret is not initialized so it contains garbage. Ensure garbage is not returned in the case that pdata && pdata->teardown is false by initializing ret to 0. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-pca953x.c')
-rw-r--r--drivers/gpio/gpio-pca953x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 5d059866d17a..f170c5678289 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -848,7 +848,7 @@ static int pca953x_remove(struct i2c_client *client)
{
struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev);
struct pca953x_chip *chip = i2c_get_clientdata(client);
- int ret;
+ int ret = 0;
if (pdata && pdata->teardown) {
ret = pdata->teardown(client, chip->gpio_chip.base,