aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-tqmx86.c
diff options
context:
space:
mode:
authorWei Yongjun <weiyongjun1@huawei.com>2019-02-01 09:18:41 +0000
committerLinus Walleij <linus.walleij@linaro.org>2019-02-09 11:33:37 +0100
commit96be65d12d792b3e177505db1225e1ec4f9cf5cd (patch)
tree3cb307879af68882082841a7fab85c9a4221876c /drivers/gpio/gpio-tqmx86.c
parentgpio: Add a Gateworks PLD GPIO driver (diff)
downloadlinux-dev-96be65d12d792b3e177505db1225e1ec4f9cf5cd.tar.xz
linux-dev-96be65d12d792b3e177505db1225e1ec4f9cf5cd.zip
gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe()
It's not necessary to remove gpio_chip which added with devm_gpiochip_add_data(). Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-tqmx86.c')
-rw-r--r--drivers/gpio/gpio-tqmx86.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c
index 6f7250c6f597..33dbe483f92f 100644
--- a/drivers/gpio/gpio-tqmx86.c
+++ b/drivers/gpio/gpio-tqmx86.c
@@ -291,7 +291,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
IRQ_TYPE_EDGE_BOTH);
if (ret) {
dev_err(dev, "Could not add irq chip\n");
- goto out_remove;
+ goto out_pm_dis;
}
gpiochip_set_chained_irqchip(chip, irq_chip,
@@ -309,8 +309,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
return 0;
-out_remove:
- gpiochip_remove(&gpio->chip);
out_pm_dis:
pm_runtime_disable(&pdev->dev);