diff options
| author |   Dmitry Osipenko <digetx@gmail.com> | 2020-07-09 20:11:59 +0300 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2020-07-16 10:50:40 +0200 |
| commit | 2a5e6f7eede8cd1c4bac0b8ec6491cec4e75c99a (patch) | |
| tree | dda26a6325fba4c5cf0b3d1077d2b75c0ca92539 /drivers/gpio | |
| parent | gpio: max77620: Replace 8 with MAX77620_GPIO_NR (diff) | |
| download | linux-dev-2a5e6f7eede8cd1c4bac0b8ec6491cec4e75c99a.tar.xz linux-dev-2a5e6f7eede8cd1c4bac0b8ec6491cec4e75c99a.zip | |
gpio: max77620: Fix missing release of interrupt
The requested interrupt is never released by the driver. Fix this by
using the resource-managed variant of request_threaded_irq().
Fixes: ab3dd9cc24d4 ("gpio: max77620: Fix interrupt handling")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: <stable@vger.kernel.org> # 5.5+
Link: https://lore.kernel.org/r/20200709171203.12950-3-digetx@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-max77620.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c index 4c0c9ec2587d..7f7e8d4bf0d3 100644 --- a/drivers/gpio/gpio-max77620.c +++ b/drivers/gpio/gpio-max77620.c @@ -305,8 +305,9 @@ static int max77620_gpio_probe(struct platform_device *pdev) gpiochip_irqchip_add_nested(&mgpio->gpio_chip, &max77620_gpio_irqchip, 0, handle_edge_irq, IRQ_TYPE_NONE); - ret = request_threaded_irq(gpio_irq, NULL, max77620_gpio_irqhandler, - IRQF_ONESHOT, "max77620-gpio", mgpio); + ret = devm_request_threaded_irq(&pdev->dev, gpio_irq, NULL, + max77620_gpio_irqhandler, IRQF_ONESHOT, + "max77620-gpio", mgpio); if (ret < 0) { dev_err(&pdev->dev, "failed to request IRQ: %d\n", ret); return ret; |