diff options
| author |   Linus Walleij <linus.walleij@linaro.org> | 2019-06-26 10:11:17 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2019-06-27 15:56:52 +0100 |
| commit | 8df9d7f70f87960b6ad2b4a90db755551d7ab7bd (patch) | |
| tree | 38adf6b409e62dba093e28151db96266a8e10fd8 /drivers/gpio | |
| parent | gpio: siox: Do not call gpiochip_remove() on errorpath (diff) | |
| download | linux-dev-8df9d7f70f87960b6ad2b4a90db755551d7ab7bd.tar.xz linux-dev-8df9d7f70f87960b6ad2b4a90db755551d7ab7bd.zip | |
gpio: siox: Switch to IRQ_TYPE_NONE
The siox driver is hardcoding a default type of
IRQ_TYPE_EDGE_RISING to the irq helper, but this should only
be applicable to old boardfiles and odd device tree irqchips
with just onecell irq (no flags). I doubt this is the case
with the siox, I think all consumers specify the flags they
use in the device tree.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-siox.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-siox.c b/drivers/gpio/gpio-siox.c index 0b4450118865..40067e1535d3 100644 --- a/drivers/gpio/gpio-siox.c +++ b/drivers/gpio/gpio-siox.c @@ -247,7 +247,7 @@ static int gpio_siox_probe(struct siox_device *sdevice) } ret = gpiochip_irqchip_add(&ddata->gchip, &ddata->ichip, - 0, handle_level_irq, IRQ_TYPE_EDGE_RISING); + 0, handle_level_irq, IRQ_TYPE_NONE); if (ret) dev_err(&sdevice->dev, "Failed to register irq chip (%d)\n", ret); |