diff options
| author |   Wei Yongjun <weiyongjun1@huawei.com> | 2018-07-11 13:19:38 +0000 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2018-07-13 10:03:37 +0200 |
| commit | 9506755633d0b32ef76f67c345000178e9b0dfc4 (patch) | |
| tree | 21b2c66ed10e22d83729264923a92352a189ab73 /drivers/gpio | |
| parent | gpio: mt7621: add OF_GPIO dependency (diff) | |
| download | linux-dev-9506755633d0b32ef76f67c345000178e9b0dfc4.tar.xz linux-dev-9506755633d0b32ef76f67c345000178e9b0dfc4.zip | |
gpio: pxa: Fix potential NULL dereference
platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.
This is detected by Coccinelle semantic patch.
@@
expression pdev, res, n, t, e, e1, e2;
@@
res = platform_get_resource(pdev, t, n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-pxa.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index 1e66f808051c..0d09a4fcef49 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -646,6 +646,8 @@ static int pxa_gpio_probe(struct platform_device *pdev) pchip->irq0 = irq0; pchip->irq1 = irq1; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; gpio_reg_base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!gpio_reg_base) |