diff options
| author |   Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2020-05-12 21:27:21 +0300 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2020-05-18 09:16:31 +0200 |
| commit | d850c6f42cd8edcb019cfae5f00b1432d0d1a3c5 (patch) | |
| tree | 872ec1a5c8d50d68bf577a6a4428a4105d9cf7a5 /drivers/gpio | |
| parent | gpio: xgene-sb: Allow driver to be built with COMPILE_TEST (diff) | |
| download | linux-dev-d850c6f42cd8edcb019cfae5f00b1432d0d1a3c5.tar.xz linux-dev-d850c6f42cd8edcb019cfae5f00b1432d0d1a3c5.zip | |
gpio: xgene-sb: Drop extra check to call acpi_gpiochip_request_interrupts()
There is no need to have an additional check to call
acpi_gpiochip_request_interrupts(). Even without any interrupts available
the registered ACPI Event handlers can be useful for debugging purposes.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200512182721.55127-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-xgene-sb.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index 203a268dd09c..a809609ee957 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c @@ -290,10 +290,8 @@ static int xgene_gpio_sb_probe(struct platform_device *pdev) dev_info(&pdev->dev, "X-Gene GPIO Standby driver registered\n"); - if (priv->nirq > 0) { - /* Register interrupt handlers for gpio signaled acpi events */ - acpi_gpiochip_request_interrupts(&priv->gc); - } + /* Register interrupt handlers for GPIO signaled ACPI Events */ + acpi_gpiochip_request_interrupts(&priv->gc); return ret; } @@ -302,9 +300,7 @@ static int xgene_gpio_sb_remove(struct platform_device *pdev) { struct xgene_gpio_sb *priv = platform_get_drvdata(pdev); - if (priv->nirq > 0) { - acpi_gpiochip_free_interrupts(&priv->gc); - } + acpi_gpiochip_free_interrupts(&priv->gc); irq_domain_remove(priv->irq_domain); |