diff options
| author |   Felix Kuehling <Felix.Kuehling@amd.com> | 2022-11-01 15:02:48 -0400 |
|---|---|---|
| committer |   Alex Deucher <alexander.deucher@amd.com> | 2022-11-09 17:57:48 -0500 |
| commit | b91c23e099f0b65d62159da13458c5eefa76083f (patch) | |
| tree | 0b85c10adc5206cd246f6a40d8044d4b140f87ad /drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | |
| parent | drm/amdkfd: Fix error handling in kfd_criu_restore_events (diff) | |
| download | linux-dev-b91c23e099f0b65d62159da13458c5eefa76083f.tar.xz linux-dev-b91c23e099f0b65d62159da13458c5eefa76083f.zip | |
drm/amdkfd: Fix error handling in criu_checkpoint
Checkpoint BOs last. That way we don't need to close dmabuf FDs if
something else fails later. This avoids problematic access to user mode
memory in the error handling code path.
criu_checkpoint_bos has its own error handling and cleanup that does not
depend on access to user memory.
In the private data, keep BOs before the remaining objects. This is
necessary to restore things in the correct order as restoring events
depends on the events-page BO being restored first.
Fixes: be072b06c739 ("drm/amdkfd: CRIU export BOs as prime dmabuf objects")
Reported-by: Jann Horn <jannh@google.com>
CC: Rajneesh Bhardwaj <Rajneesh.Bhardwaj@amd.com>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-and-tested-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h')
0 files changed, 0 insertions, 0 deletions