diff options
| author |   Dave Airlie <airlied@redhat.com> | 2017-09-29 15:44:54 +1000 |
|---|---|---|
| committer |   Alex Deucher <alexander.deucher@amd.com> | 2017-09-29 13:02:21 -0400 |
| commit | b08c3ca4e90d03b3a120f4e60dba4b2b5e087433 (patch) | |
| tree | a9ccc554e707c30a2e6ccaa6073d0d1b761bca89 /drivers/gpu/drm/amd/display/dc/i2caux/dce110/i2c_sw_engine_dce110.c | |
| parent | amdgpu/dc: make some audio functions return void (diff) | |
| download | linux-dev-b08c3ca4e90d03b3a120f4e60dba4b2b5e087433.tar.xz linux-dev-b08c3ca4e90d03b3a120f4e60dba4b2b5e087433.zip | |
amdgpu/dc: remove pointless returns in the i2caux constructor paths. (v2)
There was lots of return true, and error checking that was never used
in these paths.
Just remove it all.
v2: I missed one return true.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/display/dc/i2caux/dce110/i2c_sw_engine_dce110.c')
| -rw-r--r-- | drivers/gpu/drm/amd/display/dc/i2caux/dce110/i2c_sw_engine_dce110.c | 20 |
1 files changed, 4 insertions, 16 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/i2caux/dce110/i2c_sw_engine_dce110.c b/drivers/gpu/drm/amd/display/dc/i2caux/dce110/i2c_sw_engine_dce110.c index bf2c4b240b78..3aa7f791e523 100644 --- a/drivers/gpu/drm/amd/display/dc/i2caux/dce110/i2c_sw_engine_dce110.c +++ b/drivers/gpu/drm/amd/display/dc/i2caux/dce110/i2c_sw_engine_dce110.c @@ -118,7 +118,7 @@ static const struct engine_funcs engine_funcs = { .submit_request = dal_i2c_sw_engine_submit_request, }; -static bool construct( +static void construct( struct i2c_sw_engine_dce110 *engine_dce110, const struct i2c_sw_engine_dce110_create_arg *arg_dce110) { @@ -127,11 +127,7 @@ static bool construct( arg_base.ctx = arg_dce110->ctx; arg_base.default_speed = arg_dce110->default_speed; - if (!dal_i2c_sw_engine_construct( - &engine_dce110->base, &arg_base)) { - ASSERT_CRITICAL(false); - return false; - } + dal_i2c_sw_engine_construct(&engine_dce110->base, &arg_base); /*struct engine struct engine_funcs*/ engine_dce110->base.base.base.funcs = &engine_funcs; @@ -139,8 +135,6 @@ static bool construct( engine_dce110->base.base.funcs = &i2c_engine_funcs; engine_dce110->base.default_speed = arg_dce110->default_speed; engine_dce110->engine_id = arg_dce110->engine_id; - - return true; } struct i2c_engine *dal_i2c_sw_engine_dce110_create( @@ -161,12 +155,6 @@ struct i2c_engine *dal_i2c_sw_engine_dce110_create( return NULL; } - if (construct(engine_dce110, arg)) - return &engine_dce110->base.base; - - ASSERT_CRITICAL(false); - - kfree(engine_dce110); - - return NULL; + construct(engine_dce110, arg); + return &engine_dce110->base.base; } |