diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-03-21 09:28:22 +0300 |
|---|---|---|
| committer |   Alex Deucher <alexander.deucher@amd.com> | 2019-03-21 14:05:26 -0500 |
| commit | 6c851417336af718587a83b27fbe83480c31fc2f (patch) | |
| tree | 6f6a78b62a88f787f2d1540992db70c50cab8e17 /drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | |
| parent | drm/amd/powerplay: Off by one in vega20_get_smu_msg_index() (diff) | |
| download | linux-dev-6c851417336af718587a83b27fbe83480c31fc2f.tar.xz linux-dev-6c851417336af718587a83b27fbe83480c31fc2f.zip | |
drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table()
We already unlocked a few lines earlier so this code unlocks twice on
the success path.
Fixes: 289921b03fe5e ("drm/amd/powerplay: implement sysfs of pp_table for smu11 (v2)")
Reviewed-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Kevin Wang <kevin1.wang@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/powerplay/amdgpu_smu.c')
| -rw-r--r-- | drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c index 00b7c885772b..7e8c74da6a74 100644 --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c @@ -187,6 +187,8 @@ int smu_sys_set_pp_table(struct smu_context *smu, void *buf, size_t size) if (ret) pr_info("smu reset failed, ret = %d\n", ret); + return ret; + failed: mutex_unlock(&smu->mutex); return ret; |