diff options
| author |   Tomi Valkeinen <tomi.valkeinen@ti.com> | 2019-06-10 16:57:38 +0300 |
|---|---|---|
| committer |   Andrzej Hajda <a.hajda@samsung.com> | 2019-06-14 09:46:14 +0200 |
| commit | c08f99c39083ab55a9c93b3e93cef48711294dad (patch) | |
| tree | 9817eb10981127f2759fbc3107eacdf63e84e5cf /drivers/gpu/drm/bridge/ti-tfp410.c | |
| parent | drm/sun4i: sun6i_mipi_dsi: Fix hsync_porch overflow (diff) | |
| download | linux-dev-c08f99c39083ab55a9c93b3e93cef48711294dad.tar.xz linux-dev-c08f99c39083ab55a9c93b3e93cef48711294dad.zip | |
drm/bridge: tfp410: fix memleak in get_modes()
We don't free the edid blob allocated by the call to drm_get_edid(),
causing a memleak. Fix this by calling kfree(edid) at the end of the
get_modes().
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190610135739.6077-1-tomi.valkeinen@ti.com
Diffstat (limited to 'drivers/gpu/drm/bridge/ti-tfp410.c')
| -rw-r--r-- | drivers/gpu/drm/bridge/ti-tfp410.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index 8b0e71bd3ca7..9f0836cc712b 100644 --- a/drivers/gpu/drm/bridge/ti-tfp410.c +++ b/drivers/gpu/drm/bridge/ti-tfp410.c @@ -70,7 +70,12 @@ static int tfp410_get_modes(struct drm_connector *connector) drm_connector_update_edid_property(connector, edid); - return drm_add_edid_modes(connector, edid); + ret = drm_add_edid_modes(connector, edid); + + kfree(edid); + + return ret; + fallback: /* No EDID, fallback on the XGA standard modes */ ret = drm_add_modes_noedid(connector, 1920, 1200); |