diff options
| author |   Peter Rosin <peda@axentia.se> | 2018-08-06 08:19:10 +0200 |
|---|---|---|
| committer |   Andrzej Hajda <a.hajda@samsung.com> | 2018-09-13 11:28:12 +0200 |
| commit | 169cc4c7a14e988985c8833ddec2f3e897de2c28 (patch) | |
| tree | 924ed403ff547e1d148956aaa6bf4c75e0024f8a /drivers/gpu/drm/drm_bridge.c | |
| parent | drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg (diff) | |
| download | linux-dev-169cc4c7a14e988985c8833ddec2f3e897de2c28.tar.xz linux-dev-169cc4c7a14e988985c8833ddec2f3e897de2c28.zip | |
drm: bridge: document bridge attach/detach imbalance
Since commit 4a878c03d562 ("drm: bridge: Detach bridge from encoder at
encoder cleanup time"), it is generally no longer correct to detach bridges
from encoders manually. Document that.
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180806061910.29914-3-peda@axentia.se
Diffstat (limited to 'drivers/gpu/drm/drm_bridge.c')
| -rw-r--r-- | drivers/gpu/drm/drm_bridge.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 1638bfe9627c..ba7025041e46 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -104,6 +104,10 @@ EXPORT_SYMBOL(drm_bridge_remove); * If non-NULL the previous bridge must be already attached by a call to this * function. * + * Note that bridges attached to encoders are auto-detached during encoder + * cleanup in drm_encoder_cleanup(), so drm_bridge_attach() should generally + * *not* be balanced with a drm_bridge_detach() in driver code. + * * RETURNS: * Zero on success, error code on failure */ |