diff options
| author |   Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> | 2020-08-14 13:01:40 -0400 |
|---|---|---|
| committer |   Lyude Paul <lyude@redhat.com> | 2020-08-17 11:54:10 -0400 |
| commit | 88fee1c9007a38c19f2c558dc0ab1ddb4c323dc5 (patch) | |
| tree | 9a4b25d59f1765e16d08a87f1da1eecffc273ac3 /drivers/gpu/drm/drm_dp_mst_topology.c | |
| parent | drm/virtio: fix memory leak in virtio_gpu_cleanup_object() (diff) | |
| download | linux-dev-88fee1c9007a38c19f2c558dc0ab1ddb4c323dc5.tar.xz linux-dev-88fee1c9007a38c19f2c558dc0ab1ddb4c323dc5.zip | |
drm/dp_mst: Don't return error code when crtc is null
[Why]
In certain cases the crtc can be NULL and returning -EINVAL causes
atomic check to fail when it shouln't. This leads to valid
configurations failing because atomic check fails.
[How]
Don't early return if crtc is null
Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
[added stable cc]
Signed-off-by: Lyude Paul <lyude@redhat.com>
Fixes: 8ec046716ca8 ("drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCs")
Cc: <stable@vger.kernel.org> # v5.6+
Link: https://patchwork.freedesktop.org/patch/msgid/20200814170140.24917-1-Bhawanpreet.Lakha@amd.com
Diffstat (limited to 'drivers/gpu/drm/drm_dp_mst_topology.c')
| -rw-r--r-- | drivers/gpu/drm/drm_dp_mst_topology.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 1e26b89628f9..0a2f0b5c7a44 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -4990,8 +4990,8 @@ int drm_dp_mst_add_affected_dsc_crtcs(struct drm_atomic_state *state, struct drm crtc = conn_state->crtc; - if (WARN_ON(!crtc)) - return -EINVAL; + if (!crtc) + continue; if (!drm_dp_mst_dsc_aux_for_port(pos->port)) continue; |