diff options
| author |   Simon Ser <contact@emersion.fr> | 2020-12-11 19:46:33 +0100 |
|---|---|---|
| committer | Simon Ser <contact@emersion.fr> | 2020-12-15 16:46:55 +0100 |
| commit | 2200736a0c4d3f3195410c1fa95aae579a107d28 (patch) | |
| tree | 9c0058e5a8e08e1aa053ba661f93d224d04873f1 /drivers/gpu/drm/drm_plane.c | |
| parent | drm: validate possible_crtcs for primary and cursor planes (diff) | |
| download | linux-dev-2200736a0c4d3f3195410c1fa95aae579a107d28.tar.xz linux-dev-2200736a0c4d3f3195410c1fa95aae579a107d28.zip | |
drm: require a non_NULL drm_crtc.primary
If a CRTC is missing a legacy primary plane pointer, a lot of things
will be broken for user-space: fbdev stops working and the entire legacy
uAPI stops working.
Require all drivers to populate drm_crtc.primary to prevent these
issues. Warn if it's NULL.
Signed-off-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201211184634.74534-3-contact@emersion.fr
Diffstat (limited to 'drivers/gpu/drm/drm_plane.c')
| -rw-r--r-- | drivers/gpu/drm/drm_plane.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 5d33ca9f0032..49b0a8b9ac02 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -57,7 +57,7 @@ * Legacy uAPI doesn't expose the primary and cursor planes directly. DRM core * relies on the driver to set the primary and optionally the cursor plane used * for legacy IOCTLs. This is done by calling drm_crtc_init_with_planes(). All - * drivers should provide one primary plane per CRTC to avoid surprising legacy + * drivers must provide one primary plane per CRTC to avoid surprising legacy * userspace too much. */ |