diff options
| author |   Andrzej Hajda <a.hajda@samsung.com> | 2016-09-26 16:50:21 +0900 |
|---|---|---|
| committer |   Inki Dae <daeinki@gmail.com> | 2016-10-01 00:39:35 +0900 |
| commit | 14e022f3041d5b0406c7d7175e350e0bf420e625 (patch) | |
| tree | 31ae4026254263a97c3dafb3f5acce921a11368f /drivers/gpu/drm/exynos/exynos_drm_drv.h | |
| parent | drm/exynos/vidi: use timer for vblanks instead of sleeping worker (diff) | |
| download | linux-dev-14e022f3041d5b0406c7d7175e350e0bf420e625.tar.xz linux-dev-14e022f3041d5b0406c7d7175e350e0bf420e625.zip | |
drm/exynos: fix pending update handling
Exynos DRM devices update their registers at vblank time. Exynos-DRM uses
custom mechanism to wait for vblank. This mechanism is error prone -
variables are not updated atomically. As a result in certain circumstances
user space can try to free buffers which are still in use by hardware,
in such cases IOMMU can throw OOPS.
The patch instead of fixing the mechanism replaces it with drm core helper.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Diffstat (limited to 'drivers/gpu/drm/exynos/exynos_drm_drv.h')
| -rw-r--r-- | drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h index 7f1a49d5bdbe..cee3a4c76106 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h @@ -173,8 +173,6 @@ struct exynos_drm_crtc { enum exynos_drm_output_type type; unsigned int pipe; struct drm_pending_vblank_event *event; - wait_queue_head_t wait_update; - atomic_t pending_update; const struct exynos_drm_crtc_ops *ops; void *ctx; struct exynos_drm_clk *pipe_clk; |