diff options
| author |   Matthew Auld <matthew.auld@intel.com> | 2021-10-27 17:18:13 +0100 |
|---|---|---|
| committer | Matthew Auld <matthew.auld@intel.com> | 2021-11-02 09:44:10 +0000 |
| commit | 068b1bd0925387ff3a2900726a681ce697e4c1a9 (patch) | |
| tree | 640f33f64807927bf62fc8ba1127a69d7381003d /drivers/gpu/drm/i915/gem/i915_gem_pages.c | |
| parent | drm/i915: move cpu_write_needs_clflush (diff) | |
| download | linux-dev-068b1bd0925387ff3a2900726a681ce697e4c1a9.tar.xz linux-dev-068b1bd0925387ff3a2900726a681ce697e4c1a9.zip | |
drm/i915: stop setting cache_dirty on discrete
Should not be needed. Even with non-coherent display, we should be using
device local-memory there, and not system memory.
v2: also add a warning in i915_gem_clflush_object
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20211027161813.3094681-4-matthew.auld@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/gem/i915_gem_pages.c')
| -rw-r--r-- | drivers/gpu/drm/i915/gem/i915_gem_pages.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c index 308e22a80af4..c4f684b7cc51 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c @@ -26,6 +26,7 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj, /* Make the pages coherent with the GPU (flushing any swapin). */ if (obj->cache_dirty) { + WARN_ON_ONCE(IS_DGFX(i915)); obj->write_domain = 0; if (i915_gem_object_has_struct_page(obj)) drm_clflush_sg(pages); |