aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/i915_dma.c
diff options
context:
space:
mode:
authorMatt Roper <matthew.d.roper@intel.com>2016-03-04 15:59:39 -0800
committerImre Deak <imre.deak@intel.com>2016-03-22 14:48:27 +0200
commit177246a84d133888b5428e44201282d94635f473 (patch)
tree11b8ba39159d9ca6e0a13155026397cc85fb6f54 /drivers/gpu/drm/i915/i915_dma.c
parentdrm/i915/tdr: Prepare error handler to accept mask of hung engines (diff)
downloadlinux-dev-177246a84d133888b5428e44201282d94635f473.tar.xz
linux-dev-177246a84d133888b5428e44201282d94635f473.zip
drm/i915: Wait until after wm optimization to drop runtime PM reference
At the end of an atomic commit, we currently wait for vblanks to complete, call put() on the various runtime PM references, and then try to optimize our watermarks (on platforms that need two-step watermark programming). This can lead to watermark registers being programmed while the power well is powered down. We need to wait until after watermark optimization is complete before dropping our runtime power references. Note that in the future the watermark optimization is probably going to move to an asynchronous workqueue task that happens at some arbitrary point after vblank. When we make that change, we'll no longer necessarily be operating under the power reference held here, so we'll need to wrap the watermark register programmin in a call to intel_runtime_pm_get_if_in_use() or similar. Cc: arun.siluvery@linux.intel.com Cc: ville.syrjala@linux.intel.com Cc: maarten.lankhorst@linux.intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94349 Fixes: ed4a6a7ca853 ("drm/i915: Add two-stage ILK-style watermark programming (v11)") Signed-off-by: Matt Roper <matthew.d.roper@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1457135979-23727-1-git-send-email-matthew.d.roper@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/i915_dma.c')
0 files changed, 0 insertions, 0 deletions