diff options
| author |   Matthew Auld <matthew.auld@intel.com> | 2022-04-20 19:16:11 +0100 |
|---|---|---|
| committer | Matthew Auld <matthew.auld@intel.com> | 2022-04-21 10:10:35 +0100 |
| commit | be77bb3e8d4d47a3ab7bd2dd5bf76092b33e08a2 (patch) | |
| tree | cf55af5c185cd5ee19cc41a78278566c775e7ab5 /drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | |
| parent | drm/i915: consider min_page_size when migrating (diff) | |
| download | linux-dev-be77bb3e8d4d47a3ab7bd2dd5bf76092b33e08a2.tar.xz linux-dev-be77bb3e8d4d47a3ab7bd2dd5bf76092b33e08a2.zip | |
drm/i915/buddy: sanity check the size
Ensure we check that the size is compatible with the requested
page_size. For tiny objects that are automatically annotated with
TTM_PL_FLAG_CONTIGUOUS(since they fit within a single page), we
currently end up silently overriding the min_page_size, which ends up
hiding bugs elsewhere.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220420181613.70033-2-matthew.auld@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/i915_ttm_buddy_manager.c')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c b/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c index 8e4e3f72c1ef..a5109548abc0 100644 --- a/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c +++ b/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c @@ -70,6 +70,7 @@ static int i915_ttm_buddy_man_alloc(struct ttm_resource_manager *man, min_page_size = bo->page_alignment << PAGE_SHIFT; GEM_BUG_ON(min_page_size < mm->chunk_size); + GEM_BUG_ON(!IS_ALIGNED(size, min_page_size)); if (place->fpfn + bman_res->base.num_pages != place->lpfn && place->flags & TTM_PL_FLAG_CONTIGUOUS) { |