diff options
| author |   Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> | 2015-05-20 09:03:27 +0300 |
|---|---|---|
| committer |   Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-05-20 11:26:11 +0200 |
| commit | 7546a38411fc3eb9e0ff1252718b0bf6579c87f6 (patch) | |
| tree | bab30a9cc3f3724f0cf0dc6aba5a3d45a4d2912f /drivers/gpu/drm/i915/intel_display.c | |
| parent | drm/i915/skl: add F0 stepping ID (diff) | |
| download | linux-dev-7546a38411fc3eb9e0ff1252718b0bf6579c87f6.tar.xz linux-dev-7546a38411fc3eb9e0ff1252718b0bf6579c87f6.zip | |
drm/i915: Update comment in clear_intel_crtc_state()
Explain why a few fields of the new pipe_config have their values
preserved, while the others are zeroed.
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_display.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 9d2d6fbbf3e3..4a34709794f0 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -11485,7 +11485,11 @@ clear_intel_crtc_state(struct intel_crtc_state *crtc_state) enum intel_dpll_id shared_dpll; uint32_t ddi_pll_sel; - /* Clear only the intel specific part of the crtc state excluding scalers */ + /* FIXME: before the switch to atomic started, a new pipe_config was + * kzalloc'd. Code that depends on any field being zero should be + * fixed, so that the crtc_state can be safely duplicated. For now, + * only fields that are know to not cause problems are preserved. */ + tmp_state = crtc_state->base; scaler_state = crtc_state->scaler_state; shared_dpll = crtc_state->shared_dpll; |