diff options
| author |   Joonas Lahtinen <joonas.lahtinen@linux.intel.com> | 2017-02-08 15:12:09 +0200 |
|---|---|---|
| committer | Joonas Lahtinen <joonas.lahtinen@linux.intel.com> | 2017-02-08 17:22:00 +0200 |
| commit | 3c779a49bd7ce6c9ecc35a679f28f94fe3cfaeab (patch) | |
| tree | a2db24065313d5907e5179baad66ab3ef5948d33 /drivers/gpu/drm/i915/intel_fbdev.c | |
| parent | drm/i915: Always convert incoming exec offsets to non-canonical (diff) | |
| download | linux-dev-3c779a49bd7ce6c9ecc35a679f28f94fe3cfaeab.tar.xz linux-dev-3c779a49bd7ce6c9ecc35a679f28f94fe3cfaeab.zip | |
drm/i915: Avoid BIT(max) - 1 and use GENMASK(max - 1, 0)
"BIT(max) - 1" will overflow when max = 32, and GCC will complain.
We already have GENMASK for generating the mask, use it!
v2: Majestic off by one spotted (Chris)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_fbdev.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_fbdev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c index e0d9e72cf3d1..03b7391fb566 100644 --- a/drivers/gpu/drm/i915/intel_fbdev.c +++ b/drivers/gpu/drm/i915/intel_fbdev.c @@ -371,7 +371,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper, return false; memcpy(save_enabled, enabled, count); - mask = BIT(count) - 1; + mask = GENMASK(count - 1, 0); conn_configured = 0; retry: for (i = 0; i < count; i++) { |