diff options
| author |   Chuanxiao Dong <chuanxiao.dong@intel.com> | 2017-05-11 18:07:42 +0800 |
|---|---|---|
| committer |   Jani Nikula <jani.nikula@intel.com> | 2017-05-19 11:45:10 +0300 |
| commit | 46cd902f6d9a746f0da816cbdfb04b9baf6d7967 (patch) | |
| tree | 3a18462a1e6402d6c6c1ca6a036964c95ac0eb5e /drivers/gpu/drm/i915/intel_lrc.c | |
| parent | drm/i915: Fix new -Wint-in-bool-context gcc compiler warning (diff) | |
| download | linux-dev-46cd902f6d9a746f0da816cbdfb04b9baf6d7967.tar.xz linux-dev-46cd902f6d9a746f0da816cbdfb04b9baf6d7967.zip | |
drm/i915: set initialised only when init_context callback is NULL
During execlist_context_deferred_alloc() we presumed that the context is
uninitialised (we only just allocated the state object for it!) and
chose to optimise away the later call to engine->init_context() if
engine->init_context were NULL. This breaks with GVT's contexts that are
marked as pre-initialised to avoid us annoyingly calling
engine->init_context(). The fix is to not override ce->initialised if it
is already true.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1494497262-24855-1-git-send-email-chuanxiao.dong@intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
(cherry picked from commit 0d402a24df8c8160727af934d83293f3d44d31a3)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_lrc.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_lrc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index c8f7c631fc1f..dac4e003c1f3 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@ -1989,7 +1989,7 @@ static int execlists_context_deferred_alloc(struct i915_gem_context *ctx, ce->ring = ring; ce->state = vma; - ce->initialised = engine->init_context == NULL; + ce->initialised |= engine->init_context == NULL; return 0; |