diff options
| author |   Imre Deak <imre.deak@intel.com> | 2014-09-08 15:21:09 +0300 |
|---|---|---|
| committer |   Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-09-19 14:43:13 +0200 |
| commit | 950eabaf5a87257040e0c207be09487954113f54 (patch) | |
| tree | cdf3f4f9eb393edf24344b5a33f2d7da350c1ed0 /drivers/gpu/drm/i915/intel_ringbuffer.c | |
| parent | drm/i915: Only set CURSOR_PIPE_CSC_ENABLE when cursor is enabled (diff) | |
| download | linux-dev-950eabaf5a87257040e0c207be09487954113f54.tar.xz linux-dev-950eabaf5a87257040e0c207be09487954113f54.zip | |
drm/i915: vlv: fix display IRQ enable/disable
We want to enable/disable display IRQs only if global i915 IRQs are
enabled. To check the latter it's not enough to consult the DRM
dev->irq_enabled flag, since runtime PM can disable/enable IRQs
and it won't adjust this flag only the i915 specific
dev_priv->pm._irqs_disabled flag. Fix this by using the proper
intel_irqs_enabled() helper instead.
Fortunately this didn't cause an actual problem since even if we enabled
display IRQs too early (before enabling global i915 IRQs) the
VLV_MASTER_IER would still be clear masking all IRQs.
This issue was caught by
commit 920dd15a2b2fc60d054646a8a1ffd6aeb6090e05
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Wed Aug 27 10:43:37 2014 +0200
drm/i915: WARN if interrupts aren't on in en/disable_pipestat
Signed-off-by: Imre Deak <imre.deak@intel.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_ringbuffer.c')
0 files changed, 0 insertions, 0 deletions