diff options
| author |   Ville Syrjälä <ville.syrjala@linux.intel.com> | 2019-04-10 20:09:41 +0300 |
|---|---|---|
| committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2019-06-07 20:42:02 +0300 |
| commit | bca29283dcc058739c41d2fd9110d8ebc3e0f5e8 (patch) | |
| tree | 3b6b002beb0ae678c54a987ba134be49895e8946 /drivers/gpu/drm/i915/intel_sdvo.c | |
| parent | drm/i915/sdvo: Don't write stack garbage into the hbuf (diff) | |
| download | linux-dev-bca29283dcc058739c41d2fd9110d8ebc3e0f5e8.tar.xz linux-dev-bca29283dcc058739c41d2fd9110d8ebc3e0f5e8.zip | |
drm/i915/sdvo: Actually print the reason why the SDVO command failed
It's much easier to figure out why the SDVO encoder refuses to cooperate
if we can see what status we got back.
v2: Zero initialize only the first character, not the whole buffer
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190410170941.28142-1-ville.syrjala@linux.intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_sdvo.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_sdvo.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index 6d78fd165642..0860ae36bb87 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/drm/i915/intel_sdvo.c @@ -522,6 +522,7 @@ static bool intel_sdvo_read_response(struct intel_sdvo *intel_sdvo, #define BUF_LEN 256 char buffer[BUF_LEN]; + buffer[0] = '\0'; /* * The documentation states that all commands will be @@ -585,7 +586,8 @@ static bool intel_sdvo_read_response(struct intel_sdvo *intel_sdvo, return true; log_fail: - DRM_DEBUG_KMS("%s: R: ... failed\n", SDVO_NAME(intel_sdvo)); + DRM_DEBUG_KMS("%s: R: ... failed %s\n", + SDVO_NAME(intel_sdvo), buffer); return false; } |