diff options
| author |   Lucas Stach <l.stach@pengutronix.de> | 2018-04-11 17:31:35 +0200 |
|---|---|---|
| committer |   Philipp Zabel <p.zabel@pengutronix.de> | 2018-07-16 16:56:34 +0200 |
| commit | b58262396fabd43dc869b576e3defdd23b32fe94 (patch) | |
| tree | 11b26258e408c85b9d464fc823ae7ec6b18b083c /drivers/gpu/drm/imx | |
| parent | Linux 4.18-rc1 (diff) | |
| download | linux-dev-b58262396fabd43dc869b576e3defdd23b32fe94.tar.xz linux-dev-b58262396fabd43dc869b576e3defdd23b32fe94.zip | |
drm/imx: imx-ldb: disable LDB on driver bind
The LVDS signal integrity is only guaranteed when the correct enable
sequence (first IPU DI, then LDB) is used. If the LDB display output was
active before the imx-drm driver is loaded (like when a bootsplash was
active) the DI will be disabled by the full IPU reset we do when loading
the driver. The LDB control registers are not part of the IPU range and
thus will remain unchanged.
This leads to the LDB still being active when the DI is getting enabled,
effectively reversing the required enable sequence. Fix this by also
disabling the LDB on driver bind.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Diffstat (limited to 'drivers/gpu/drm/imx')
| -rw-r--r-- | drivers/gpu/drm/imx/imx-ldb.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index 56dd7a9a8e25..17974c0b4be8 100644 --- a/drivers/gpu/drm/imx/imx-ldb.c +++ b/drivers/gpu/drm/imx/imx-ldb.c @@ -612,6 +612,9 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data) return PTR_ERR(imx_ldb->regmap); } + /* disable LDB by resetting the control register to POR default */ + regmap_write(imx_ldb->regmap, IOMUXC_GPR2, 0); + imx_ldb->dev = dev; if (of_id) |