diff options
| author |   Qinglang Miao <miaoqinglang@huawei.com> | 2020-11-27 17:44:38 +0800 |
|---|---|---|
| committer |   Qiang Yu <yuq825@gmail.com> | 2021-01-30 11:25:36 +0800 |
| commit | de499781c97d96703af8a32d2b5e37fdb5b51568 (patch) | |
| tree | eebae7187d30f388ae4d200312e23ec1b9918365 /drivers/gpu/drm/lima/lima_sched.c | |
| parent | drm/scheduler: Job timeout handler returns status (v3) (diff) | |
| download | linux-dev-de499781c97d96703af8a32d2b5e37fdb5b51568.tar.xz linux-dev-de499781c97d96703af8a32d2b5e37fdb5b51568.zip | |
drm/lima: fix reference leak in lima_pm_busy
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to putting operation will result in a
reference leak here.
A new function pm_runtime_resume_and_get is introduced in
[0] to keep usage counter balanced. So We fix the reference
leak by replacing it with new function.
[0] commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
Fixes: 50de2e9ebbc0 ("drm/lima: enable runtime pm")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201127094438.121003-1-miaoqinglang@huawei.com
Diffstat (limited to 'drivers/gpu/drm/lima/lima_sched.c')
| -rw-r--r-- | drivers/gpu/drm/lima/lima_sched.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c index 6e4273852712..20dafa62980f 100644 --- a/drivers/gpu/drm/lima/lima_sched.c +++ b/drivers/gpu/drm/lima/lima_sched.c @@ -201,7 +201,7 @@ static int lima_pm_busy(struct lima_device *ldev) int ret; /* resume GPU if it has been suspended by runtime PM */ - ret = pm_runtime_get_sync(ldev->dev); + ret = pm_runtime_resume_and_get(ldev->dev); if (ret < 0) return ret; |