aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/msm/msm_atomic.c
diff options
context:
space:
mode:
authorRob Clark <robdclark@chromium.org>2020-10-20 15:26:00 -0700
committerRob Clark <robdclark@chromium.org>2020-11-01 10:13:09 -0800
commitcb21f3f882ad12811331c1067b9acfc4dd359d3f (patch)
treea71e1bfa236a2e8da1e132ad942637fa5de65b51 /drivers/gpu/drm/msm/msm_atomic.c
parentdrm/msm: Fix race condition in msm driver with async layer updates (diff)
downloadlinux-dev-cb21f3f882ad12811331c1067b9acfc4dd359d3f.tar.xz
linux-dev-cb21f3f882ad12811331c1067b9acfc4dd359d3f.zip
drm/msm/atomic: Drop per-CRTC locks in reverse order
lockdep dislikes seeing locks unwound in a non-nested fashion. Fixes: b3d91800d9ac ("drm/msm: Fix race condition in msm driver with async layer updates") Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Diffstat (limited to 'drivers/gpu/drm/msm/msm_atomic.c')
-rw-r--r--drivers/gpu/drm/msm/msm_atomic.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c
index 575e9af9b6fc..93d39608a073 100644
--- a/drivers/gpu/drm/msm/msm_atomic.c
+++ b/drivers/gpu/drm/msm/msm_atomic.c
@@ -67,7 +67,7 @@ static void unlock_crtcs(struct msm_kms *kms, unsigned int crtc_mask)
{
struct drm_crtc *crtc;
- for_each_crtc_mask(kms->dev, crtc, crtc_mask)
+ for_each_crtc_mask_reverse(kms->dev, crtc, crtc_mask)
mutex_unlock(&kms->commit_lock[drm_crtc_index(crtc)]);
}