diff options
| author |   Stephane Viau <sviau@codeaurora.org> | 2015-09-15 08:41:46 -0400 |
|---|---|---|
| committer |   Rob Clark <robdclark@gmail.com> | 2015-10-22 15:39:54 -0400 |
| commit | 5e921b19268d87a0c64f3181c0d3ea9df9eea972 (patch) | |
| tree | 4cb1fefee21aaa06740a64b067c6836ce53fe7ae /drivers/gpu/drm/msm/msm_gpu.c | |
| parent | drm/msm/mdp5: remove the cfg pointer from SMP struct (diff) | |
| download | linux-dev-5e921b19268d87a0c64f3181c0d3ea9df9eea972.tar.xz linux-dev-5e921b19268d87a0c64f3181c0d3ea9df9eea972.zip | |
drm/msm: Fix IOMMU clean up path in case msm_iommu_new() fails
msm_iommu_new() can fail and this change makes sure that we
detect the failure and free the allocated domain before going
any further.
Signed-off-by: Stephane Viau <sviau@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Diffstat (limited to 'drivers/gpu/drm/msm/msm_gpu.c')
| -rw-r--r-- | drivers/gpu/drm/msm/msm_gpu.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 8f70d9248ac5..6b02ada6579a 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -651,6 +651,14 @@ int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev, if (iommu) { dev_info(drm->dev, "%s: using IOMMU\n", name); gpu->mmu = msm_iommu_new(&pdev->dev, iommu); + if (IS_ERR(gpu->mmu)) { + ret = PTR_ERR(gpu->mmu); + dev_err(drm->dev, "failed to init iommu: %d\n", ret); + gpu->mmu = NULL; + iommu_domain_free(iommu); + goto fail; + } + } else { dev_info(drm->dev, "%s: no IOMMU, fallback to VRAM carveout!\n", name); } |