diff options
| author |   YueHaibing <yuehaibing@huawei.com> | 2019-12-30 10:46:28 +0800 |
|---|---|---|
| committer |   Ben Skeggs <bskeggs@redhat.com> | 2020-01-15 10:49:59 +1000 |
| commit | 2574c809d7c0f07f11fdefd9894e51e126ee1d66 (patch) | |
| tree | a881d434fac01175a3dc63edeaffcd89f8bd4b41 /drivers/gpu/drm/nouveau/dispnv04 | |
| parent | drm/nouveau/ce/gp10b: Use correct copy engine (diff) | |
| download | linux-dev-2574c809d7c0f07f11fdefd9894e51e126ee1d66.tar.xz linux-dev-2574c809d7c0f07f11fdefd9894e51e126ee1d66.zip | |
drm/nouveau/kms/nv04-nv4x: Use match_string() helper to simplify the code
match_string() returns the array index of a matching string.
Use it instead of the open-coded implementation.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/nouveau/dispnv04')
| -rw-r--r-- | drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c index 03466f04c741..3a9489ed6544 100644 --- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c +++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c @@ -644,16 +644,13 @@ static int nv17_tv_create_resources(struct drm_encoder *encoder, int i; if (nouveau_tv_norm) { - for (i = 0; i < num_tv_norms; i++) { - if (!strcmp(nv17_tv_norm_names[i], nouveau_tv_norm)) { - tv_enc->tv_norm = i; - break; - } - } - - if (i == num_tv_norms) + i = match_string(nv17_tv_norm_names, num_tv_norms, + nouveau_tv_norm); + if (i < 0) NV_WARN(drm, "Invalid TV norm setting \"%s\"\n", nouveau_tv_norm); + else + tv_enc->tv_norm = i; } drm_mode_create_tv_properties(dev, num_tv_norms, nv17_tv_norm_names); |