aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/panel/panel-lvds.c
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2019-08-23 22:32:43 +0300
committerSam Ravnborg <sam@ravnborg.org>2019-08-24 10:42:48 +0200
commit6dbe0c4b0fc0646442b2b1580d022404e582fd7b (patch)
treea9b0b7860bb5d0577bac6bfaf13b42ef86517360 /drivers/gpu/drm/panel/panel-lvds.c
parentdrm/panel: Add missing drm_panel_init() in panel drivers (diff)
downloadlinux-dev-6dbe0c4b0fc0646442b2b1580d022404e582fd7b.tar.xz
linux-dev-6dbe0c4b0fc0646442b2b1580d022404e582fd7b.zip
drm/panel: Initialise panel dev and funcs through drm_panel_init()
Instead of requiring all drivers to set the dev and funcs fields of drm_panel manually after calling drm_panel_init(), pass the data as arguments to the function. This simplifies the panel drivers, and will help future refactoring when adding new arguments to drm_panel_init(). The panel drivers have been updated with the following Coccinelle semantic patch, with manual inspection to verify that no call to drm_panel_init() with a single argument still exists. @@ expression panel; expression device; identifier ops; @@ drm_panel_init(&panel + , device, &ops ); ... ( -panel.dev = device; -panel.funcs = &ops; | -panel.funcs = &ops; -panel.dev = device; ) Suggested-by: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20190823193245.23876-3-laurent.pinchart@ideasonboard.com
Diffstat (limited to 'drivers/gpu/drm/panel/panel-lvds.c')
-rw-r--r--drivers/gpu/drm/panel/panel-lvds.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index ad47cc95459e..3dc1ac2a6b03 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -260,9 +260,7 @@ static int panel_lvds_probe(struct platform_device *pdev)
*/
/* Register the panel. */
- drm_panel_init(&lvds->panel);
- lvds->panel.dev = lvds->dev;
- lvds->panel.funcs = &panel_lvds_funcs;
+ drm_panel_init(&lvds->panel, lvds->dev, &panel_lvds_funcs);
ret = drm_panel_add(&lvds->panel);
if (ret < 0)