aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/panel/panel-novatek-nt35510.c
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2022-07-08 11:49:22 +0200
committerSam Ravnborg <sam@ravnborg.org>2022-07-09 10:50:03 +0200
commit79abca2b399009eb8d12c652d0f0f7a9c7a06289 (patch)
tree0a095113b58582b43e543fddd9a9a14e23cea27f /drivers/gpu/drm/panel/panel-novatek-nt35510.c
parentdrm/panel-novatek-nt35510: Emit an error message if power off fails (diff)
downloadlinux-dev-79abca2b399009eb8d12c652d0f0f7a9c7a06289.tar.xz
linux-dev-79abca2b399009eb8d12c652d0f0f7a9c7a06289.zip
drm/mipi-dsi: Make remove callback return void
All implementations return 0 and the return value of mipi_dsi_drv_remove() is ignored anyhow. So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20220708094922.1408248-4-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/gpu/drm/panel/panel-novatek-nt35510.c')
-rw-r--r--drivers/gpu/drm/panel/panel-novatek-nt35510.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35510.c b/drivers/gpu/drm/panel/panel-novatek-nt35510.c
index 1b3e0154bfb8..c613ad967ba6 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt35510.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt35510.c
@@ -966,7 +966,7 @@ static int nt35510_probe(struct mipi_dsi_device *dsi)
return 0;
}
-static int nt35510_remove(struct mipi_dsi_device *dsi)
+static void nt35510_remove(struct mipi_dsi_device *dsi)
{
struct nt35510 *nt = mipi_dsi_get_drvdata(dsi);
int ret;
@@ -978,8 +978,6 @@ static int nt35510_remove(struct mipi_dsi_device *dsi)
dev_err(&dsi->dev, "Failed to power off\n");
drm_panel_remove(&nt->panel);
-
- return 0;
}
/*