diff options
| author |   Paul Cercueil <paul@crapouillou.net> | 2020-08-20 14:12:55 +0200 |
|---|---|---|
| committer | Paul Cercueil <paul@crapouillou.net> | 2020-08-20 18:34:28 +0200 |
| commit | 2f4b769e4d18c1a38dc892668971fc2f0c4e6f5b (patch) | |
| tree | 254dec9d5e3cc4ad5baaf23e7b495348b407989f /drivers/gpu/drm/panel/panel-novatek-nt39016.c | |
| parent | drm/ttm: fix broken merge between drm-next and drm-misc-next (diff) | |
| download | linux-dev-2f4b769e4d18c1a38dc892668971fc2f0c4e6f5b.tar.xz linux-dev-2f4b769e4d18c1a38dc892668971fc2f0c4e6f5b.zip | |
drm/panel: novatek,nt39016: Reorder calls in probe
The drm_panel_of_backlight() function must be called after
drm_panel_init(), according to the function's documentation; otherwise
the backlight won't be properly initialized.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20200820121256.32037-2-paul@crapouillou.net
Diffstat (limited to 'drivers/gpu/drm/panel/panel-novatek-nt39016.c')
| -rw-r--r-- | drivers/gpu/drm/panel/panel-novatek-nt39016.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm/panel/panel-novatek-nt39016.c index 39f7be679da5..daa583030246 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt39016.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt39016.c @@ -285,6 +285,9 @@ static int nt39016_probe(struct spi_device *spi) return PTR_ERR(panel->map); } + drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs, + DRM_MODE_CONNECTOR_DPI); + err = drm_panel_of_backlight(&panel->drm_panel); if (err) { if (err != -EPROBE_DEFER) @@ -292,9 +295,6 @@ static int nt39016_probe(struct spi_device *spi) return err; } - drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs, - DRM_MODE_CONNECTOR_DPI); - drm_panel_add(&panel->drm_panel); return 0; |