diff options
| author |   Boris Brezillon <boris.brezillon@collabora.com> | 2020-02-06 15:13:27 +0100 |
|---|---|---|
| committer |   Rob Herring <robh@kernel.org> | 2020-02-12 14:27:29 -0600 |
| commit | dde2bb2da01e96c17f0a44b4a3cf72a30e66e3ef (patch) | |
| tree | 6238a4f5c71a2e81bd2adec0e5a67e2bcffc30d4 /drivers/gpu/drm/panfrost/panfrost_mmu.c | |
| parent | drm/panfrost: Remove set but not used variable 'bo' (diff) | |
| download | linux-dev-dde2bb2da01e96c17f0a44b4a3cf72a30e66e3ef.tar.xz linux-dev-dde2bb2da01e96c17f0a44b4a3cf72a30e66e3ef.zip | |
drm/panfrost: perfcnt: Reserve/use the AS attached to the perfcnt MMU context
We need to use the AS attached to the opened FD when dumping counters.
Reported-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Fixes: 7282f7645d06 ("drm/panfrost: Implement per FD address spaces")
Cc: <stable@vger.kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Tested-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200206141327.446127-1-boris.brezillon@collabora.com
Diffstat (limited to 'drivers/gpu/drm/panfrost/panfrost_mmu.c')
| -rw-r--r-- | drivers/gpu/drm/panfrost/panfrost_mmu.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c index 763cfca886a7..3107b0738e40 100644 --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c @@ -151,7 +151,12 @@ u32 panfrost_mmu_as_get(struct panfrost_device *pfdev, struct panfrost_mmu *mmu) as = mmu->as; if (as >= 0) { int en = atomic_inc_return(&mmu->as_count); - WARN_ON(en >= NUM_JOB_SLOTS); + + /* + * AS can be retained by active jobs or a perfcnt context, + * hence the '+ 1' here. + */ + WARN_ON(en >= (NUM_JOB_SLOTS + 1)); list_move(&mmu->list, &pfdev->as_lru_list); goto out; |