diff options
| author |   Nicholas Mc Guire <hofrat@osadl.org> | 2016-07-19 21:54:06 +0200 |
|---|---|---|
| committer |   Alex Deucher <alexander.deucher@amd.com> | 2016-07-29 14:36:45 -0400 |
| commit | ecb2caae6aa7e33a8b413479d802a6b818316f97 (patch) | |
| tree | 9b5a5f10103066d1477d1a30cf5d8941c9f3f40a /drivers/gpu/drm/radeon/ci_dpm.c | |
| parent | drm/amdgpu: Disable RPM helpers while reprobing connectors on resume (diff) | |
| download | linux-dev-ecb2caae6aa7e33a8b413479d802a6b818316f97.tar.xz linux-dev-ecb2caae6aa7e33a8b413479d802a6b818316f97.zip | |
drm/radeon/ci add comment to document intentionally unreachable code
commit d967be9b80a5 ("drm/radeon/ci: disable needless sclk changes")
introduces an unreachable if(C != C) conditional code section
flagged by coccinelle script bad_conditional.cocci:
Add a comment to make it clear that this is intentional.
Fixes: d967be9b80a5 ("drm/radeon/ci: disable needless sclk changes")
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/radeon/ci_dpm.c')
| -rw-r--r-- | drivers/gpu/drm/radeon/ci_dpm.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c index 35e0fc3ae8a7..7ba450832e6b 100644 --- a/drivers/gpu/drm/radeon/ci_dpm.c +++ b/drivers/gpu/drm/radeon/ci_dpm.c @@ -3843,7 +3843,10 @@ static void ci_find_dpm_states_clocks_in_dpm_table(struct radeon_device *rdev, if (i >= sclk_table->count) { pi->need_update_smu7_dpm_table |= DPMTABLE_OD_UPDATE_SCLK; } else { - /* XXX check display min clock requirements */ + /* XXX The current code always reprogrammed the sclk levels, + * but we don't currently handle disp sclk requirements + * so just skip it. + */ if (CISLAND_MINIMUM_ENGINE_CLOCK != CISLAND_MINIMUM_ENGINE_CLOCK) pi->need_update_smu7_dpm_table |= DPMTABLE_UPDATE_SCLK; } |