diff options
| author |   Melissa Wen <melissa.srw@gmail.com> | 2020-07-30 17:25:24 -0300 |
|---|---|---|
| committer |   Daniel Vetter <daniel.vetter@ffwll.ch> | 2020-08-02 15:22:31 +0200 |
| commit | 0986191186128b10b6bbfa5220fc587ed5725e49 (patch) | |
| tree | b67d9143d66f21e42a9ca9cb6f7dfa87a601e6e5 /drivers/gpu/drm/vkms/vkms_composer.c | |
| parent | drm/panel: simple: Add Chefree CH101OLHLWH-002 panel (diff) | |
| download | linux-dev-0986191186128b10b6bbfa5220fc587ed5725e49.tar.xz linux-dev-0986191186128b10b6bbfa5220fc587ed5725e49.zip | |
drm/vkms: fix xrgb on compute crc
The previous memset operation was not correctly zeroing the alpha
channel to compute the crc, and as a result, the IGT subtest
kms_cursor_crc/pipe-A-cursor-alpha-transparent fails.
Fixes: db7f419c06d7c ("drm/vkms: Compute CRC with Cursor Plane")
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200730202524.5upzuh4irboru7my@smtp.gmail.com
Diffstat (limited to 'drivers/gpu/drm/vkms/vkms_composer.c')
| -rw-r--r-- | drivers/gpu/drm/vkms/vkms_composer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c index 4af2f19480f4..b8b060354667 100644 --- a/drivers/gpu/drm/vkms/vkms_composer.c +++ b/drivers/gpu/drm/vkms/vkms_composer.c @@ -33,7 +33,7 @@ static uint32_t compute_crc(void *vaddr_out, struct vkms_composer *composer) + (i * composer->pitch) + (j * composer->cpp); /* XRGB format ignores Alpha channel */ - memset(vaddr_out + src_offset + 24, 0, 8); + bitmap_clear(vaddr_out + src_offset, 24, 8); crc = crc32_le(crc, vaddr_out + src_offset, sizeof(u32)); } |