diff options
| author |   Zack Rusin <zackr@vmware.com> | 2021-05-04 23:57:35 -0400 |
|---|---|---|
| committer | Zack Rusin <zackr@vmware.com> | 2021-05-11 13:06:56 -0400 |
| commit | 2cc8bfeeb7366a24f3ad726c05117984b89a90e1 (patch) | |
| tree | 02622ceccd5acb4f92346979288c86c9bf683920 /drivers/gpu/drm/vmwgfx | |
| parent | drm/vc4: Remove redundant error printing in vc4_ioremap_regs() (diff) | |
| download | linux-dev-2cc8bfeeb7366a24f3ad726c05117984b89a90e1.tar.xz linux-dev-2cc8bfeeb7366a24f3ad726c05117984b89a90e1.zip | |
drm/vmwgfx: Fix incorrect enum usage
SVGA_REG_ENABLE is a register name, and SVGA_REG_ENABLE_(ENABLE|
DISABLE|HIDE) are its valid values. We were incorrectly setting
the register value to itself. This happened to work because
the SVGA_REG_ENABLE is happens to to be the same value as
SVGA_REG_ENABLE_ENABLE, but is still semantically incorrect.
Lets use the correct enum when setting SVGA_REG_ENABLE.
Signed-off-by: Zack Rusin <zackr@vmware.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210505035740.286923-2-zackr@vmware.com
Diffstat (limited to 'drivers/gpu/drm/vmwgfx')
| -rw-r--r-- | drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 7805ba0e1c49..1b27d7f7fcfa 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -1179,7 +1179,7 @@ static void __vmw_svga_enable(struct vmw_private *dev_priv) struct ttm_resource_manager *man = ttm_manager_type(&dev_priv->bdev, TTM_PL_VRAM); if (!ttm_resource_manager_used(man)) { - vmw_write(dev_priv, SVGA_REG_ENABLE, SVGA_REG_ENABLE); + vmw_write(dev_priv, SVGA_REG_ENABLE, SVGA_REG_ENABLE_ENABLE); ttm_resource_manager_set_used(man, true); } } |