aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/xlnx
diff options
context:
space:
mode:
authorMaxime Ripard <maxime@cerno.tech>2021-01-29 17:06:47 +0100
committerMaxime Ripard <maxime@cerno.tech>2021-02-02 17:34:08 +0100
commitfacd93f4285c405f9a91b05166147cb39e860666 (patch)
tree85688a341cdf53da9708bd76b9c6fb103dae387c /drivers/gpu/drm/xlnx
parentdrm/ttm: Use __GFP_NOWARN for huge pages in ttm_pool_alloc_page (diff)
downloadlinux-dev-facd93f4285c405f9a91b05166147cb39e860666.tar.xz
linux-dev-facd93f4285c405f9a91b05166147cb39e860666.zip
drm/vc4: hvs: Fix buffer overflow with the dlist handling
Commit 0a038c1c29a7 ("drm/vc4: Move LBM creation out of vc4_plane_mode_set()") changed the LBM allocation logic from first allocating the LBM memory for the plane to running mode_set, adding a gap in the LBM, and then running the dlist allocation filling that gap. The gap was introduced by incrementing the dlist array index, but was never checking whether or not we were over the array length, leading eventually to memory corruptions if we ever crossed this limit. vc4_dlist_write had that logic though, and was reallocating a larger dlist array when reaching the end of the buffer. Let's share the logic between both functions. Cc: Boris Brezillon <boris.brezillon@collabora.com> Cc: Eric Anholt <eric@anholt.net> Fixes: 0a038c1c29a7 ("drm/vc4: Move LBM creation out of vc4_plane_mode_set()") Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Link: https://patchwork.freedesktop.org/patch/msgid/20210129160647.128373-1-maxime@cerno.tech
Diffstat (limited to 'drivers/gpu/drm/xlnx')
0 files changed, 0 insertions, 0 deletions