diff options
| author |   Mikko Perttunen <mperttunen@nvidia.com> | 2017-09-28 15:50:41 +0300 |
|---|---|---|
| committer |   Thierry Reding <treding@nvidia.com> | 2017-10-20 14:19:52 +0200 |
| commit | eb2ee1a28db17155bcee4630e36ea1759b7e10dc (patch) | |
| tree | 63942452c69d2a896ca682cfe623ff9c963523b0 /drivers/gpu/host1x/debug.c | |
| parent | gpu: host1x: Enable gather filter (diff) | |
| download | linux-dev-eb2ee1a28db17155bcee4630e36ea1759b7e10dc.tar.xz linux-dev-eb2ee1a28db17155bcee4630e36ea1759b7e10dc.zip | |
gpu: host1x: Improve debug disassembly formatting
The host1x driver prints out "disassembly" dumps of the command FIFO
and gather contents on submission timeouts. However, the output has
been quite difficult to read with unnecessary newlines and occasional
missing parentheses.
Fix these problems by using pr_cont to remove unnecessary newlines
and by fixing other small issues.
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers/gpu/host1x/debug.c')
| -rw-r--r-- | drivers/gpu/host1x/debug.c | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c index 2aae0e63214c..dc77ec452ffc 100644 --- a/drivers/gpu/host1x/debug.c +++ b/drivers/gpu/host1x/debug.c @@ -40,7 +40,19 @@ void host1x_debug_output(struct output *o, const char *fmt, ...) len = vsnprintf(o->buf, sizeof(o->buf), fmt, args); va_end(args); - o->fn(o->ctx, o->buf, len); + o->fn(o->ctx, o->buf, len, false); +} + +void host1x_debug_cont(struct output *o, const char *fmt, ...) +{ + va_list args; + int len; + + va_start(args, fmt); + len = vsnprintf(o->buf, sizeof(o->buf), fmt, args); + va_end(args); + + o->fn(o->ctx, o->buf, len, true); } static int show_channel(struct host1x_channel *ch, void *data, bool show_fifo) |