diff options
| author |   Sam Bobroff <sbobroff@linux.ibm.com> | 2019-05-21 15:28:39 +1000 |
|---|---|---|
| committer |   Gerd Hoffmann <kraxel@redhat.com> | 2019-05-21 10:06:04 +0200 |
| commit | 3c6b8625dde82600fd03ad1fcba223f1303ee535 (patch) | |
| tree | a61da23e591c07746cf423701ca4cfbbe70f4184 /drivers/gpu | |
| parent | drm/bochs: fix ptr_ret.cocci warnings (diff) | |
| download | linux-dev-3c6b8625dde82600fd03ad1fcba223f1303ee535.tar.xz linux-dev-3c6b8625dde82600fd03ad1fcba223f1303ee535.zip | |
drm/bochs: Fix connector leak during driver unload
When unloading the bochs-drm driver, a warning message is printed by
drm_mode_config_cleanup() because a reference is still held to one of
the drm_connector structs.
Correct this by calling drm_atomic_helper_shutdown() in
bochs_pci_remove().
Fixes: 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up helpers.")
Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com>
Link: http://patchwork.freedesktop.org/patch/msgid/93b363ad62f4938d9ddf3e05b2a61e3f66b2dcd3.1558416473.git.sbobroff@linux.ibm.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/bochs/bochs_drv.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index 4c425439c77d..e7512a6564a3 100644 --- a/drivers/gpu/drm/bochs/bochs_drv.c +++ b/drivers/gpu/drm/bochs/bochs_drv.c @@ -10,6 +10,7 @@ #include <linux/slab.h> #include <drm/drm_fb_helper.h> #include <drm/drm_probe_helper.h> +#include <drm/drm_atomic_helper.h> #include "bochs.h" @@ -158,6 +159,7 @@ static void bochs_pci_remove(struct pci_dev *pdev) { struct drm_device *dev = pci_get_drvdata(pdev); + drm_atomic_helper_shutdown(dev); drm_dev_unregister(dev); bochs_unload(dev); drm_dev_put(dev); |