diff options
| author |   Jeffrey Hugo <jeffrey.l.hugo@gmail.com> | 2019-06-26 11:00:15 -0700 |
|---|---|---|
| committer |   Sean Paul <seanpaul@chromium.org> | 2019-08-01 12:52:21 -0400 |
| commit | 9ca7ad6c7706edeae331c1632d0c63897418ebad (patch) | |
| tree | a5393834a1b61c4d7de40995b0ed026b37528471 /drivers/gpu | |
| parent | drm/msm: Annotate intentional switch statement fall throughs (diff) | |
| download | linux-dev-9ca7ad6c7706edeae331c1632d0c63897418ebad.tar.xz linux-dev-9ca7ad6c7706edeae331c1632d0c63897418ebad.zip | |
drm: msm: Fix add_gpu_components
add_gpu_components() adds found GPU nodes from the DT to the match list,
regardless of the status of the nodes. This is a problem, because if the
nodes are disabled, they should not be on the match list because they will
not be matched. This prevents display from initing if a GPU node is
defined, but it's status is disabled.
Fix this by checking the node's status before adding it to the match list.
Fixes: dc3ea265b856 (drm/msm: Drop the gpu binding)
Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190626180015.45242-1-jeffrey.l.hugo@gmail.com
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/msm/msm_drv.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index c226156f2dea..c356f5ccf253 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -1279,7 +1279,8 @@ static int add_gpu_components(struct device *dev, if (!np) return 0; - drm_of_component_match_add(dev, matchptr, compare_of, np); + if (of_device_is_available(np)) + drm_of_component_match_add(dev, matchptr, compare_of, np); of_node_put(np); |