diff options
| author |   Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2016-02-15 19:41:47 +0100 |
|---|---|---|
| committer |   Alex Deucher <alexander.deucher@amd.com> | 2016-02-16 10:05:50 -0500 |
| commit | bc3f5d8c4ca01555820617eb3b6c0857e4df710d (patch) | |
| tree | d88bd24b38a4d2622b1330b6ef01f64148caf2ea /drivers/gpu | |
| parent | drm/amdgpu: use post-decrement in error handling (diff) | |
| download | linux-dev-bc3f5d8c4ca01555820617eb3b6c0857e4df710d.tar.xz linux-dev-bc3f5d8c4ca01555820617eb3b6c0857e4df710d.zip | |
drm/radeon: use post-decrement in error handling
We need to use post-decrement to get the pci_map_page undone also for
i==0, and to avoid some very unpleasant behaviour if pci_map_page
failed already at i==0.
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/radeon/radeon_ttm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index e34307459e50..e06ac546a90f 100644 --- a/drivers/gpu/drm/radeon/radeon_ttm.c +++ b/drivers/gpu/drm/radeon/radeon_ttm.c @@ -758,7 +758,7 @@ static int radeon_ttm_tt_populate(struct ttm_tt *ttm) 0, PAGE_SIZE, PCI_DMA_BIDIRECTIONAL); if (pci_dma_mapping_error(rdev->pdev, gtt->ttm.dma_address[i])) { - while (--i) { + while (i--) { pci_unmap_page(rdev->pdev, gtt->ttm.dma_address[i], PAGE_SIZE, PCI_DMA_BIDIRECTIONAL); gtt->ttm.dma_address[i] = 0; |