diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-10-28 21:40:43 +0800 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2022-11-02 14:34:56 +0100 |
| commit | b5bcb94b0954a026bbd671741fdb00e7141f9c91 (patch) | |
| tree | 2091512f1209924c958b98a677a4b129270152c4 /drivers/hid/hid-hyperv.c | |
| parent | HID: asus: Remove unused variable in asus_report_tool_width() (diff) | |
| download | linux-dev-b5bcb94b0954a026bbd671741fdb00e7141f9c91.tar.xz linux-dev-b5bcb94b0954a026bbd671741fdb00e7141f9c91.zip | |
HID: hyperv: fix possible memory leak in mousevsc_probe()
If hid_add_device() returns error, it should call hid_destroy_device()
to free hid_dev which is allocated in hid_allocate_device().
Fixes: 74c4fb058083 ("HID: hv_mouse: Properly add the hid device")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-hyperv.c')
| -rw-r--r-- | drivers/hid/hid-hyperv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c index e0bc73124196..ab57b49a44ed 100644 --- a/drivers/hid/hid-hyperv.c +++ b/drivers/hid/hid-hyperv.c @@ -499,7 +499,7 @@ static int mousevsc_probe(struct hv_device *device, ret = hid_add_device(hid_dev); if (ret) - goto probe_err1; + goto probe_err2; ret = hid_parse(hid_dev); |