diff options
| author |   Roderick Colenbrander <roderick.colenbrander@sony.com> | 2019-09-04 14:22:11 -0700 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2019-09-05 14:27:14 +0200 |
| commit | 2bcdacb70327013ca2066bfcf2af1009eff01f1d (patch) | |
| tree | 2b2b8fb90f099fbef9ac4fc366415df369c88957 /drivers/hid/hid-sony.c | |
| parent | HID: i2c-hid: modify quirks for weida's devices (diff) | |
| download | linux-dev-2bcdacb70327013ca2066bfcf2af1009eff01f1d.tar.xz linux-dev-2bcdacb70327013ca2066bfcf2af1009eff01f1d.zip | |
HID: sony: Fix memory corruption issue on cleanup.
The sony driver is not properly cleaning up from potential failures in
sony_input_configured. Currently it calls hid_hw_stop, while hid_connect
is still running. This is not a good idea, instead hid_hw_stop should
be moved to sony_probe. Similar changes were recently made to Logitech
drivers, which were also doing improper cleanup.
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
CC: stable@vger.kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-sony.c')
| -rw-r--r-- | drivers/hid/hid-sony.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index 49dd2d905c7f..73c0f7a95e2d 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -2811,7 +2811,6 @@ err_stop: sony_cancel_work_sync(sc); sony_remove_dev_list(sc); sony_release_device_id(sc); - hid_hw_stop(hdev); return ret; } @@ -2876,6 +2875,7 @@ static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id) */ if (!(hdev->claimed & HID_CLAIMED_INPUT)) { hid_err(hdev, "failed to claim input\n"); + hid_hw_stop(hdev); return -ENODEV; } |