diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2017-02-19 13:07:59 +0100 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2017-03-06 14:16:13 +0100 |
| commit | d3d9adfe3059cb5cb330a2da74ea0bad49b482c0 (patch) | |
| tree | 25bb7dd98943ffcbe96a252149cd26003fdae187 /drivers/hid/i2c-hid/i2c-hid.c | |
| parent | HID: i2c-hid: support regulator power on/off (diff) | |
| download | linux-dev-d3d9adfe3059cb5cb330a2da74ea0bad49b482c0.tar.xz linux-dev-d3d9adfe3059cb5cb330a2da74ea0bad49b482c0.zip | |
HID: i2c-hid: Fix error handling
According to error handling in this function, it is likely that some
resources should be freed before returning.
Replace 'return ret', with 'goto err'.
While at it, remove some spaces at the beginning of the lines to be more
consistent.
Fixes: ead0687fe304a ("HID: i2c-hid: support regulator power on/off")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/i2c-hid/i2c-hid.c')
| -rw-r--r-- | drivers/hid/i2c-hid/i2c-hid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index a3f6daf0886b..a83814949467 100644 --- a/drivers/hid/i2c-hid/i2c-hid.c +++ b/drivers/hid/i2c-hid/i2c-hid.c @@ -1064,7 +1064,7 @@ static int i2c_hid_probe(struct i2c_client *client, if (ret != -EPROBE_DEFER) dev_err(&client->dev, "Failed to get regulator: %d\n", ret); - return ret; + goto err; } ret = regulator_enable(ihid->pdata.supply); |