diff options
| author |   Anirudh Rayabharam <mail@anirudhrb.com> | 2021-04-25 23:03:53 +0530 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2021-05-05 15:52:34 +0200 |
| commit | 6be388f4a35d2ce5ef7dbf635a8964a5da7f799f (patch) | |
| tree | 6e4a7f2bd3471fa91be4a74f4eeafe49d77598eb /drivers/hid/i2c-hid | |
| parent | HID: Add BUS_VIRTUAL to hid_connect logging (diff) | |
| download | linux-dev-6be388f4a35d2ce5ef7dbf635a8964a5da7f799f.tar.xz linux-dev-6be388f4a35d2ce5ef7dbf635a8964a5da7f799f.zip | |
HID: usbhid: fix info leak in hid_submit_ctrl
In hid_submit_ctrl(), the way of calculating the report length doesn't
take into account that report->size can be zero. When running the
syzkaller reproducer, a report of size 0 causes hid_submit_ctrl) to
calculate transfer_buffer_length as 16384. When this urb is passed to
the usb core layer, KMSAN reports an info leak of 16384 bytes.
To fix this, first modify hid_report_len() to account for the zero
report size case by using DIV_ROUND_UP for the division. Then, call it
from hid_submit_ctrl().
Reported-by: syzbot+7c2bb71996f95a82524c@syzkaller.appspotmail.com
Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/i2c-hid')
0 files changed, 0 insertions, 0 deletions