diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2015-05-14 11:33:30 +0300 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2015-05-18 11:22:53 +0200 |
| commit | c8fd51dc12c6e22bb97d5e273babcf339770aba5 (patch) | |
| tree | 334902c961b74e0af2ac437a7f7e5f85eebc559b /drivers/hid/i2c-hid | |
| parent | HID: rmi: fix some harmless BIT() mistakes (diff) | |
| download | linux-dev-c8fd51dc12c6e22bb97d5e273babcf339770aba5.tar.xz linux-dev-c8fd51dc12c6e22bb97d5e273babcf339770aba5.zip | |
HID: i2c-hid: fix harmless test_bit() issue
These defines are used like this:
if (test_bit(I2C_HID_STARTED, &ihid->flags))
The intent was to use bits 0, 1, and 2 but because of the extra shifts
we're using bits 1, 2, and 4. It's harmless becuase it's done
consistently but it's not the intent and static checkers will complain.
Fixes: 4a200c3b9a40 ('HID: i2c-hid: introduce HID over i2c specification implementation')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/i2c-hid')
| -rw-r--r-- | drivers/hid/i2c-hid/i2c-hid.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index ab4dd952b6ba..ea5ce752cb47 100644 --- a/drivers/hid/i2c-hid/i2c-hid.c +++ b/drivers/hid/i2c-hid/i2c-hid.c @@ -42,9 +42,9 @@ #include <linux/i2c/i2c-hid.h> /* flags */ -#define I2C_HID_STARTED (1 << 0) -#define I2C_HID_RESET_PENDING (1 << 1) -#define I2C_HID_READ_PENDING (1 << 2) +#define I2C_HID_STARTED 0 +#define I2C_HID_RESET_PENDING 1 +#define I2C_HID_READ_PENDING 2 #define I2C_HID_PWR_ON 0x00 #define I2C_HID_PWR_SLEEP 0x01 |