diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2017-03-27 18:51:18 +0100 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2017-04-06 14:47:17 +0200 |
| commit | 040fc001765d374776353cb4f8b03ea7fa41e3cd (patch) | |
| tree | 057eb5e0c32fd43dc8a37043305d3129ac74c6e0 /drivers/hid | |
| parent | HID: sony: Make sure to unregister sensors on failure (diff) | |
| download | linux-dev-040fc001765d374776353cb4f8b03ea7fa41e3cd.tar.xz linux-dev-040fc001765d374776353cb4f8b03ea7fa41e3cd.zip | |
HID: sony: remove redundant check for -ve err
err is being checked for failure each time it is being updated
so this err check is totally redundant and can be removed
Detected with CoverityScan, CID#1420665 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-sony.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index e90ce63897df..43213d6ff2d1 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -2654,9 +2654,6 @@ static int sony_input_configured(struct hid_device *hdev, ret = 0; } - if (ret < 0) - goto err_stop; - if (sc->quirks & SONY_LED_SUPPORT) { ret = sony_leds_init(sc); if (ret < 0) |