diff options
| author |   Allen Hung <allen_hung@dell.com> | 2016-06-23 16:31:29 +0800 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2016-06-28 13:24:14 +0200 |
| commit | 62630ea768869beeb1e514b0bf5607a0c9b93d12 (patch) | |
| tree | 659d6ac0b2ab5568d359003824fad75ae6990f05 /drivers/hid | |
| parent | HID: hiddev: validate num_values for HIDIOCGUSAGES, HIDIOCSUSAGES commands (diff) | |
| download | linux-dev-62630ea768869beeb1e514b0bf5607a0c9b93d12.tar.xz linux-dev-62630ea768869beeb1e514b0bf5607a0c9b93d12.zip | |
Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection
if device implements confidence usage")
The commit enables palm rejection for Win8 Precision Touchpad devices but
the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very
properly. This quirk is originally designed for some WIn7 touchscreens. Use
of this for a Win8 Precision Touchpad will cause unexpected pointer jumping
problem.
Cc: stable@vger.kernel.org # v4.5+
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3
Signed-off-by: Allen Hung <allen_hung@dell.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-multitouch.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 95b7d61d9910..4ef700688657 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi, mt_store_field(usage, td, hi); return 1; case HID_DG_CONFIDENCE: - if (cls->name == MT_CLS_WIN_8 && - field->application == HID_DG_TOUCHPAD) { - cls->quirks &= ~MT_QUIRK_ALWAYS_VALID; - cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE; - } mt_store_field(usage, td, hi); return 1; case HID_DG_TIPSWITCH: |