diff options
| author |   Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2013-06-19 17:49:05 +0200 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2013-06-19 23:53:52 +0200 |
| commit | 6f1891d01956cad406d2af8ed2e9cef6108bfc5e (patch) | |
| tree | 1d186e77590a46a3242604fd74d488699b7f7afa /drivers/hid | |
| parent | HID: roccat: check cdev_add return value (diff) | |
| download | linux-dev-6f1891d01956cad406d2af8ed2e9cef6108bfc5e.tar.xz linux-dev-6f1891d01956cad406d2af8ed2e9cef6108bfc5e.zip | |
HID: fix false positive out of range values
Commit 6da7066906e977d42104a859c490f5f9a300488c introduced in 3.3
"HID: ignore absolute values which don't fit between logical min and max"
prevents some Posiflex touch screen to work because they do not provide
logical min and max for their buttons.
Thus, logical min and max are at 0, discarding the buttons events, and
preventing the device to report appropriate X Y.
Adding a check on "min < max" solves the problem.
Reported-by: Jan Kandziora <jjj@gmx.de>
Tested-by: Jan Kandziora <jjj@gmx.de>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-input.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 945b8158ec4c..82130cf724e4 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1045,6 +1045,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct * section 5.10 and 6.2.25 */ if ((field->flags & HID_MAIN_ITEM_VARIABLE) && + (field->logical_minimum < field->logical_maximum) && (value < field->logical_minimum || value > field->logical_maximum)) { dbg_hid("Ignoring out-of-range value %x\n", value); |